lib: deprecate _stream_* modules
#58337
Open
+81
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
dario-piotrowicz
added
semver-major
There was a problem hiding this comment.
file renamed for consistency with the others I'm adding
dario-piotrowicz
force-pushed
the
dario/deprecate_stream
branch
from
2bd8325 to
5eda2b3
Compare
dario-piotrowicz
changed the title
_stream_* modules
dario-piotrowicz
force-pushed
the
dario/deprecate_stream
branch
from
5eda2b3 to
1e6ac2d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58337 +/- ##
==========================================
- Coverage 90.23% 90.23% -0.01%
==========================================
Files 633 633
Lines 186818 186824 +6
Branches 36668 36678 +10
==========================================
+ Hits 168578 168581 +3
- Misses 11036 11044 +8
+ Partials 7204 7199 -5
🚀 New features to boost your workflow:
|
dario-piotrowicz
force-pushed
the
dario/deprecate_stream
branch
from
1e6ac2d to
a9137e5
Compare
dario-piotrowicz
added
lib / src
RaisinTen
approved these changes
May 16, 2025
dario-piotrowicz
added
author ready
github-actions
bot
removed
the
request-ci
marco-ippolito
approved these changes
May 16, 2025
benjamingr
approved these changes
May 16, 2025
|
The rational for not doc-deprecating first is because it's undocumented? |
Yes, also because of its low usage as mentioned in #57540 (comment) (where I believe |
jasnell
approved these changes
May 16, 2025
MattiasBuelens
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime deprecation of all the
_stream_*modules (besides_stream_wrapwhich is already deprecated)This PR follows #57643 as part of my effort for trying to deprecate the various
_modules that are not documentedand that should not be part of node.js' public API (for more context see: #57540 (comment))